Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct types for websocket exceptions #50

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

timwoj
Copy link
Member

@timwoj timwoj commented Dec 5, 2024

After the upgrade to Python 3.9, some of the types we were using for the websocket package changed. This fixes the code to use the right types.

After the upgrade to Python 3.9, some of the types we were using
for the websocket package changed. This fixes the code to use the
right types.
@timwoj timwoj requested a review from ckreibich December 5, 2024 22:29
@timwoj timwoj force-pushed the topic/timw/websocket-exception-types branch from 5901917 to 85aef30 Compare December 6, 2024 00:34
@timwoj timwoj force-pushed the topic/timw/websocket-exception-types branch from 85aef30 to 4acc42e Compare December 6, 2024 01:15
Copy link
Member

@ckreibich ckreibich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim!

@timwoj timwoj merged commit 1f249e9 into master Dec 7, 2024
7 checks passed
@timwoj timwoj deleted the topic/timw/websocket-exception-types branch December 7, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants