Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom {imagesoutdir} not always respected, as it's hardcoded in text2confl #181

Open
feliksik opened this issue May 24, 2024 · 2 comments

Comments

@feliksik
Copy link

feliksik commented May 24, 2024

If I modify {imagesoutdir}, it's not always respected because it's re-configured to the workDir

There are some various scenario's (set it in text2confl.yaml, set it in the .adoc file, setting the document attribute in an extension) that behave slightly differently. I'm not detailing this all now, but I'll just put this as a mental note and refer to this minor bug in my work.

Maybe the config.attributes should be appended after parameters.extraAttrs here, but i'm not sure what side-effects that would have, as other pieces of code may make some assumptions i'm not aware of.

Feel free to keep this open or close as you see fit, given your product goals.

@zeldigas
Copy link
Owner

@feliksik this is indeed a problem, as imagesoutdir can be changed. Do you have some real world example when this is done in your case, how it breaks upload (I suppose files are not found or smth like this) and any ideas how do you want to it work?

@feliksik
Copy link
Author

My usecase is that I don't want to see the generated images; it now pollutes my workspace, and I wanted to hide them in some /tmp or .hidden directory. Now I run a rm -f diag-plantuml-md5-*.png in a script afterwards -- which also works.

So not urgent for me :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants