Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AsciiDoc] Links to mail are not properly handled when converted #96

Closed
dgautier opened this issue Sep 20, 2023 · 3 comments
Closed

[AsciiDoc] Links to mail are not properly handled when converted #96

dgautier opened this issue Sep 20, 2023 · 3 comments
Assignees
@zeldigas
Labels
asciidoc related to asciidoc files bug Something isn't working question Further information is requested

Comments

@dgautier
Copy link

Links like : mailto:[email protected]

Are not handled in asciidoc which generates :
java.nio.file.InvalidPathException: Illegal char <:> at index 6:

When resolving refrences :
at com.github.zeldigas.text2confl.convert.confluence.ReferenceProviderImpl.resolveReference(com/github/zeldigas/text2confl/convert/confluence/ReferenceProvider.kt:56)
at com.github.zeldigas.text2confl.convert.asciidoc.AsciidocReferenceProvider.resolveLink(com/github/zeldigas/text2confl/convert/asciidoc/AsciidocReferenceProvider.kt:20)
@zeldigas zeldigas self-assigned this Sep 20, 2023
@zeldigas zeldigas added bug Something isn't working asciidoc related to asciidoc files labels Sep 20, 2023
@zeldigas
Copy link
Owner

zeldigas commented Sep 21, 2023 •
edited
Loading

@dgautier could you please add asciidoc snippet to reproduce?

Tried with this, but no luck:

mailto:[email protected][Subscribe,Subscribe me,I want to participate.]

Send email to [email protected]

link:mailto:[email protected][Send email]

@zeldigas zeldigas added the question Further information is requested label Sep 21, 2023
@zeldigas
Copy link
Owner

zeldigas commented Oct 7, 2023

@dgautier any chance to provide reproducible example?

@zeldigas zeldigas mentioned this issue Nov 5, 2023
Merged
@zeldigas
Copy link
Owner

zeldigas commented Nov 5, 2023

It was fixed as a part of #116 and additionally covered by tests here: https://github.com/zeldigas/text2confl/pull/118/files#diff-0f404a0d40290a5b6cae8a8e46ecf7a893e1a446ed6d8a15bf6a4b82af18bbf8

@zeldigas zeldigas closed this as completed Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeldigas zeldigas

Labels
asciidoc related to asciidoc files bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeldigas @dgautier