unloaded pinned tabs do not show website icon

[speedy1804]

Captchas

• I have read the instructions.
• I have searched existing issues and avoided creating duplicates.
• I am not filing an enhancement request.

What happened?

As you can see, the website icons aren't shown. I don't know if this has anything to do with the latest update (1.0.1-a.18), as I've only been using pinned tabs since this update.

The way I handle my pinned tabs:

Steps to reproduce:

1. Open any website
2. Pin the opened website
3. Close the website

Reproducible?

• I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.18

What platform are you seeing the problem on?

Windows

Relevant log output

No response

[dosubot]

Hey @speedy1804! I'm here to help you with any bugs, questions, or contributions you have. Let's get this sorted out together!

The issue with pinned tabs losing their website icons might be related to recent changes in the favicon fetching logic. In the latest update (1.0.1-a.18), the code attempts to fetch favicon data for each pinned tab using PlacesUtils.promiseFaviconData(pin.url). If the fetch fails, the icon URL is set to null, which could result in the icons not being displayed ^[1].

To troubleshoot, you might want to check if the favicon fetching process is encountering any errors or if there are network issues preventing the fetch. Additionally, ensure that the URLs being pinned have accessible favicons. If the problem persists, it could be beneficial to look into any recent changes in the ZenPinnedTabManager.mjs file that might affect how favicons are handled ^[1].

To continue talking to Dosu, mention @dosu.

[Onceisenoughyo]

Can reproduce, I have my pinned tab settings to close and reset the tab to its default state when using ctrl+w. It removes the icons.

https://imgur.com/a/FvEZwIB

[cheeeebs]

Can reproduce, I have my pinned tab settings to close and reset the tab to its default state when using ctrl+w. It removes the icons.

https://imgur.com/a/FvEZwIB

Having this same issue.

[stripedgoat]

Same here!

[amtoaer]

Same here. It looks like this issue was fixed by this PR, which is included in the latest Zen Twilight build:

• Fix: Pinned tab state and favicon handling #2853

[dosubot]

Hi, @speedy1804. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

• You reported an issue with pinned tabs not displaying website icons when unloaded in version 1.0.1-a.18 on Windows.
• The issue was not present in Mozilla Firefox and might be linked to changes in favicon fetching logic.
• Several users confirmed they could reproduce the issue.
• User amtoaer noted that the issue seems resolved in the latest Zen Twilight build, linked to pull request Fix: Pinned tab state and favicon handling #2853.

Next Steps:

• Please let us know if this issue is still relevant to the latest version of the desktop repository by commenting here.
• If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

[speedy1804]

this has been fixed with the beta release

[dosubot]

Thank you for your contribution, speedy1804! We appreciate your help in keeping our issues organized.