Popup window bug

[gregorlogar991]

Captchas

• I have read the instructions.
• I have searched existing issues and avoided creating duplicates.
• I am not filing an enhancement request.

What happened?

I logged into github with Google account, that opened popup windows, where I logged into a Google account. After 2FA, I was successfully logged into GitHub, but the popup window did no close, it had content of one of my pinned tabs and was not able to close it, there were no buttons, and cmd+w was only showing homepage.

Reproducible?

• I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.18 (Firefox 132.0.1) (aarch64)

What platform are you seeing the problem on?

macOS - aarch64

Relevant log output

No response

[dosubot]

Hey @gregorlogar991, I'm here to help with any bugs or questions you have. I'm a bot designed to assist you while you wait for a human maintainer. Let's tackle this popup window issue together!

The issue you're experiencing with the popup window not closing properly after logging into GitHub with a Google account might be related to how the codebase handles closing popup windows after authentication. The closeGlance method in the ZenGlanceManager class is responsible for ensuring that popup windows close properly by checking several conditions and performing necessary cleanup operations ^[1].

However, there might be a specific issue with how pinned tabs are being handled, as the popup window displayed content from one of your pinned tabs. Unfortunately, I couldn't find specific information about handling pinned tabs in the codebase, which might be interfering with the popup window behavior.

To address this issue, you might want to investigate the closeGlance method further, especially in relation to how it interacts with pinned tabs. Additionally, checking for any platform-specific configurations for macOS could be helpful, although no specific differences were found in the available information.

To continue talking to Dosu, mention @dosu.

[chadkoh]

Just a note: in order to close the popup window, go to Menu > Toolbars > Customize Toolbar and check "Title Bar" which will give you the window controls. You can click the red X to close the window, then go back into Toolbar prefs and uncheck Title Bar to get ZB back to normal.

[MrPiggy105]

Ran into this yesterday. Command(/ctrl) shift w, while focused on the window, closes all tabs in that window. This is probably related to #2816 (although it's not a private window, it should still be ignored)

[tashilapathum]

This happaned to me as well. For me there was no problem closing the popup windows. This was happenning everytime a popup windows was opened and the process of the popup window has finished. I only had one pinned tab and only the default workspace. Also I'm a relatively new Zen user so most of the settings are defaults.

[CptnFizzbin]

ran into the same issue, #2985

[mauro-balades]

Should be fixed now 👍🏽