Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification not showing full sequence for 3+ level #548

Open
ww7 opened this issue Jul 11, 2024 · 20 comments
Open

Notification not showing full sequence for 3+ level #548

ww7 opened this issue Jul 11, 2024 · 20 comments

Comments

@ww7
Copy link

ww7 commented Jul 11, 2024

For 3 levels sequences like Fn+V,E,P, bundle notification shows only last key in sequence
e.g. P after Fn+V instead of E P.

@zenangst zenangst added the bug Something isn't working label Aug 30, 2024
@zenangst
Copy link
Owner

Yeah, I've noticed this, will investigate and fix this :)

@zenangst
Copy link
Owner

zenangst commented Sep 1, 2024

Figure out a fix for this, will be a part of the next version.

@zenangst
Copy link
Owner

@ww7 I did some changes in the latest version to fix this issue, would you mind verifying if this is fixed now?

https://github.com/zenangst/KeyboardCowboy/releases/tag/3.25.0

@ww7
Copy link
Author

ww7 commented Oct 25, 2024

@zenangst text title in notifications not fit a popup, I think it can be as line under icon and keys
or maybe resize popup, or make smaller shortcut, or show shortcut under Icon+title
(I'm using Karabiner-Elements to make Space if pressed alone as complex modifier Ctrl+Opt+Cmd)

CleanShot 2024-10-25 at 11 01 41@2x

@ww7
Copy link
Author

ww7 commented Oct 25, 2024

Now 3-rd level shows full keyboard sequence.
Only thing about levels, 2-nd level not informing about existing of 3-d.

@zenangst
Copy link
Owner

Ah, I see now.
I think you are right that we need some updates when it comes to the UI.

Only thing about levels, 2-nd level not informing about existing of 3-d.

My idea here was to:

  • First key is pressed
    • Show next level
  • Second key is pressed
    • Expand on next
  • Final key is pressed
    • Show full sequence

@ww7
Copy link
Author

ww7 commented Oct 25, 2024

Yeah, but would be good to inform if next level available, like show keys and title "next level" or arrow icon

@zenangst
Copy link
Owner

Not a bad suggestion, I'll see if we can't redesign this for the next version.

@zenangst
Copy link
Owner

Oh... and thanks a lot for all the feedback, I really appreciate it 😍

@zenangst zenangst removed bug Something isn't working fix in next version labels Oct 25, 2024
@zenangst
Copy link
Owner

The issue has evolved, so I removed the tags

@zenangst
Copy link
Owner

@ww7 worked a bit on the redesign just now.

image

@ww7
Copy link
Author

ww7 commented Oct 26, 2024

I think align left App icon to Title would be better, as we mostly reading left to right

@zenangst
Copy link
Owner

Made another iteration now

image

@ww7
Copy link
Author

ww7 commented Oct 26, 2024

Try place icon to left side in row with keys and align keys to right?
Also icon left to the title.

Apple design accent to icons (visual)

@zenangst
Copy link
Owner

zenangst commented Oct 26, 2024

Played around with this a bit more.

Now the key that you pressed has less opacity.
The next one in the sequence has a glow.

Pretty happy with how it turned out.

image

@ww7
Copy link
Author

ww7 commented Oct 27, 2024

Maybe keep Icon with Title?

CleanShot 2024-10-27 at 07 22 36

@ww7
Copy link
Author

ww7 commented Oct 31, 2024

If icon now at right, maybe also align title to right?

(I believe left side is better for both)

@ww7
Copy link
Author

ww7 commented Oct 31, 2024

Icons horizontally jumping when loading (older M1, not fastest one)

@zenangst
Copy link
Owner

zenangst commented Nov 1, 2024

@ww7 I had to remove an operator because of a crash, will take another stab at this later.
Currently my focus is on #565

@ww7
Copy link
Author

ww7 commented Dec 9, 2024

Recalling issue with notification appearance.
CleanShot 2024-12-09 at 07 15 35

  1. Icon showing only for apps? Would it be possible to show also for files?
  2. Notification truncating long sequences. Shift icon can be smaller.
  3. Title would be better to be on the same align as the icon (right)

As for me, icon can be smaller and in same line with the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants