Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update SystemWindowRelativeFocus for state tracking #542

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

zenangst
Copy link
Owner

Refactor SystemWindowRelativeFocus to a final class to handle state tracking for consumed windows and previous direction. Add new instance variables and methods to reset state and insert consumed windows. Update usages of SystemWindowRelativeFocus' methods to use instance methods instead of static methods.

Add consumed windows tracking to ensure windows are not reused. Update SystemCommandRunner to initialize and use the new SystemWindowRelativeFocus instance.

Refactor SystemWindowRelativeFocus to a final class to handle state
tracking for consumed windows and previous direction. Add new 
instance variables and methods to reset state and insert consumed 
windows. Update usages of SystemWindowRelativeFocus' methods to 
use instance methods instead of static methods.

Add consumed windows tracking to ensure windows are not reused.
Update SystemCommandRunner to initialize and use the new 
SystemWindowRelativeFocus instance.
Copy link

zenangst added 2 commits June 12, 2024 20:54
Make ContentStore's State conform to Sendable for thread safety. 
Add @mainactor annotation to improve concurrency handling in 
ConfigurationStore, SnippetController, MachPortCoordinator. 
Refactor WindowRunnerIncreaseWindowSize by removing unused 
dockSize and dockPosition calculations, simplifying the code. 
Add initialization for SystemWindowRelativeFocus in 
SystemCommandRunner for better focus handling. Add private 
modifiers to properties in RoundedCorners and use init for 
initialization.
Adjust Point, NSWorkspace, NSRunningApplication, Set, CGEvent,
Array, NSApplication, and NSAppleScript extensions to remove
the deprecated @retroactive keyword for @sendable 
conformance.
@zenangst zenangst merged commit 2ce0ab6 into main Jun 12, 2024
@zenangst zenangst deleted the system-window-relative-focus-refactor branch June 12, 2024 18:54
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant