Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StandardRb #126

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Use StandardRb #126

merged 5 commits into from
Feb 6, 2024

Conversation

bquorning
Copy link
Member

Remove the custom RuboCop configuration and use StandardRb instead.

@bquorning bquorning requested a review from a team February 6, 2024 10:43
@razumau
Copy link
Contributor

razumau commented Feb 6, 2024

Should we have a .git-blame-ignore-revs for some of these commits?

@bquorning
Standard: Fix last offenses
e162af6 
Also, configure `git blame` to ignore the 3 previous commits.
@bquorning
Copy link
Member Author

bquorning commented Feb 6, 2024 •
edited
Loading

.git-blame-ignore-revs

I added an ignore file containing the 3 first “Standard: Fix…” commit SHAs. I think the last commit, with “unsafe” changes, is ok to have show up in a git blame.

@bquorning bquorning merged commit b48b4cd into master Feb 6, 2024
17 checks passed
@bquorning bquorning deleted the bquorning/standard branch February 6, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razumau razumau razumau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bquorning @razumau