Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Deprecate scanner functionality (4.0), drop it (5.0) in favor of #91

Open
Ocramius opened this issue Sep 18, 2016 · 3 comments
Open

Deprecate scanner functionality (4.0), drop it (5.0) in favor of #91

Ocramius opened this issue Sep 18, 2016 · 3 comments

Comments

@Ocramius
Copy link
Member

Basically, parsing via regexes is simply not acceptable/viable anymore, and absolutely doesn't scale, as the syntax of PHP keeps changing.

@asgrim has been building https://github.com/Roave/BetterReflection since last year, and the library is stable/mature, so I'd suggest that we chop the head off this part of zend-code's functionality.

Thoughts?

@asgrim
Copy link

asgrim commented Sep 19, 2016

No problem here, that's the sort of thing BR can do I believe (though I'm not intimately familiar with the scanner here). If there is missing functionality in BR, I'm happy to take PRs or feature requests.

@weierophinney
Copy link
Member

I'm 👍 for this. While I've been happy we've had this feature in zend-code, it's difficult to maintain, and, particularly with the fast pace of language additions/changes, hard to keep up-to-date. The only way we could accomplish that is with a rewrite to use an AST and/or tokenization approach (the latter of which BR uses, IIRC), which would be a significant undertaking. Since another tool exists, I'd be happy to point folks to that instead.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-code; a new issue has been opened at laminas/laminas-code#17.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants