Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in stopScroll timeout #71

Open
pat-flew opened this issue Feb 26, 2020 · 0 comments
Open

Issue in stopScroll timeout #71

pat-flew opened this issue Feb 26, 2020 · 0 comments

Comments

@pat-flew
Copy link

I stumbled on an issue where the scroller will stop scrolling midway during a scroll. This would happen occasionally if the user was calling scrollToY repeatedly. I haven't checked other cases.

This line was the cause of the issue:

setTimeout(stopScroll, 99) // with cooldown time

The timeout in some cases did not fire until after another scroll had been started.

I was able to address by saving the timeout id and clearing if set at the start of scrollToY

@pat-flew pat-flew changed the title Bug in stopScroll timeout Issue in stopScroll timeout Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant