Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player page "Sign Player" button #270

Open
EthanM827 opened this issue May 4, 2020 · 6 comments
Open

Player page "Sign Player" button #270

EthanM827 opened this issue May 4, 2020 · 6 comments

Comments

@EthanM827
Copy link
Contributor

EthanM827 commented May 4, 2020

Currently working on this, it'd be a button similar to 'edit player' that allows you to enter a contract, length, and team. mostly for use with multiplayer leagues

@dumbmatter
Copy link
Member

Sounds like a good idea, I'm open to it.

@EthanM827
Copy link
Contributor Author

EthanM827 commented May 5, 2020

Quick and dirty mockup I threw together. Don't really think it should be its' own page.
https://imgur.com/a/FnuQdOI

@dumbmatter
Copy link
Member

This is only for free agents, right? If so, an easier solution might be to edit the negotiation screen, to allow a custom team/contract to be selected for any free agent signing. Advantage of that is it works for anything that links to a contract negotiation. Or is it too annoying to have to go to the negotiation screen?

If it was going to be a button on player pages, then an inline popup like that would make sense, I would just move it down next to the Negotiate button (inside a Bootstrap btn-group with it).

@EthanM827
Copy link
Contributor Author

This is only for free agents, right? If so, an easier solution might be to edit the negotiation screen, to allow a custom team/contract to be selected for any free agent signing. Advantage of that is it works for anything that links to a contract negotiation. Or is it too annoying to have to go to the negotiation screen?

Good idea. I'll make a mockup of that, and do a poll to see which people would prefer.

@mamamia5x
Copy link
Contributor

Currently working on this, it'd be a button similar to 'edit player' that allows you to enter a contract, length, and team. mostly for use with multiplayer leagues

What about on the negotiation screen, you have a side table that allows you to edit the contract. This would be only for god-mode, and it could have a dropdown list that'll show the teams you are controlling and add the contract to the team.

@mamamia5x
Copy link
Contributor

mamamia5x commented Sep 18, 2020

image

Unstyled css example.
Note: I am playing as 1 team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants