Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring DTSI to the latest state and correct RTS/CTS pin configuration #238

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

GeorgeCGV
Copy link
Contributor

@GeorgeCGV GeorgeCGV commented Nov 8, 2024

The genpinctrl.py is corrected with a patch proposed by @mathieuchopstm that handles template exceptions raised by the C0 family.

The DTSI files are regenerated with pin open data f4ec11, that removes: stm32wba50keux, modifies others, and adds some new ones.

A correction to RTS/CTS serial pins is added:

  • CTS
    • remove open-drain
  • RTS
    • replace open-drain with push-pull
    • remove pull-up bias

Such configuration shall support most use cases and provide faster RTS switching.

The DTSI files are regenerated again to include RTS/CTS configuration changes.

@GeorgeCGV GeorgeCGV force-pushed the dtsi_corrections branch 2 times, most recently from de9385e to 6bf3d2d Compare November 8, 2024 11:42
Copy link
Contributor

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor commit-related requests:

  • please change first regeneration commit's title from dts: st: regenerate all dtsi files to dts: st: regenerate all dtsi files with latest pindata
  • remove the skipped files list from genpinctrl commit's message
    • move it to dts: st: regenerate all dtsi files with latest pindata instead - with a header like The following SoCs are skipped due to incompatibility with genpinctrl:
    • I would also make the genpinctrl commit message more generic, something like:
The latest STM32 Open Pin Data revision contains SoC descriptors that
are not handled properly by genpinctrl yet. These files are parsed
properly but trigger an exception during the pinctrl template rendering.

Add exception logic around template rendering so that problematic SoC files
are skipped - with an error message - instead of crashing the script, which
would otherwise prevent regeneration of DTSI for *all* SoCs.

This allows us to keep updating the pinctrl DTSI for supported SoCs
even when new SoCs requiring genpinctrl updates are added to Pin Data.

Otherwise LGTM.

GeorgeCGV and others added 2 commits November 8, 2024 13:45
The latest STM32 Open Pin Data revision contains SoC descriptors that
are not handled properly by genpinctrl yet. These files are parsed
properly but trigger an exception during the pinctrl template rendering.

Add exception logic around template rendering so that problematic SoC files
are skipped - with an error message - instead of crashing the script, which
would otherwise prevent regeneration of DTSI for *all* SoCs.

This allows us to keep updating the pinctrl DTSI for supported SoCs
even when new SoCs requiring genpinctrl updates are added to Pin Data.

Co-authored-by: Mathieu Choplain <[email protected]>
Signed-off-by: Georgij Cernysiov <[email protected]>
Brings everything to the latest state using the current config
and pin open data f4ec11.

The following SoCs are skipped due to incompatibility with genpinctrl:
* stm32c071k8tx-pinctrl.dtsi
* stm32c071k8txn-pinctrl.dtsi
* stm32c071c8ux-pinctrl.dtsi
* stm32c071c8uxn-pinctrl.dtsi
* stm32c071cbtxn-pinctrl.dtsi
* stm32c071rbixn-pinctrl.dtsi
* stm32c071kbtx-pinctrl.dtsi
* stm32c071kbuxn-pinctrl.dtsi
* stm32c071k8uxn-pinctrl.dtsi
* stm32c071k8ux-pinctrl.dtsi
* stm32c071cbuxn-pinctrl.dtsi
* stm32c071cbux-pinctrl.dtsi
* stm32c071kbtxn-pinctrl.dtsi
* stm32c071kbux-pinctrl.dtsi
* stm32c071c8tx-pinctrl.dtsi
* stm32c071c8txn-pinctrl.dtsi
* stm32c071rbtxn-pinctrl.dtsi
* stm32c071rbtx-pinctrl.dtsi
* stm32c071r8tx-pinctrl.dtsi
* stm32c071cbtx-pinctrl.dtsi
* stm32c071r8txn-pinctrl.dtsi

Signed-off-by: Georgij Cernysiov <[email protected]>
* CTS
   - remove open-drain
* RTS
   - replace open-drain with push-pull
   - remove pull-up bias

Signed-off-by: Georgij Cernysiov <[email protected]>
Regenerate to get RTS/CTS pin configuration changes using
pin open data f4ec11.

Signed-off-by: Georgij Cernysiov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants