boards: others: add esp32c3_supermini board support #78718
+504
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
requested changes
Sep 19, 2024
rlneumiller
force-pushed
the
add_board_esp32c3_supermini
branch
from
3dc01af
to
a2e14a1
Compare
sylvioalves
reviewed
Sep 19, 2024
sylvioalves
reviewed
Sep 19, 2024
sylvioalves
reviewed
Sep 19, 2024
rlneumiller
force-pushed
the
add_board_esp32c3_supermini
branch
from
a2e14a1
to
ce7bb03
Compare
sylvioalves
previously approved these changes
Sep 19, 2024
kartben
previously approved these changes
Sep 19, 2024
nordicjm
reviewed
Sep 20, 2024
rlneumiller
dismissed stale reviews from kartben and sylvioalves
via
626fc4e
rlneumiller
force-pushed
the
add_board_esp32c3_supermini
branch
from
ce7bb03
to
626fc4e
Compare
sylvioalves
previously approved these changes
Sep 20, 2024
marekmatej
requested changes
Sep 21, 2024
|
Forget to ask for the board picture in the review :) |
rlneumiller
force-pushed
the
add_board_esp32c3_supermini
branch
3 times, most recently
from
315989d
to
2e5f449
Compare
marekmatej
reviewed
Sep 25, 2024
|
Please rephrase your commit message to have a general description of adding the new board. The message you put is more suitable for the PR description. |
rlneumiller
force-pushed
the
add_board_esp32c3_supermini
branch
from
2e5f449
to
ea8bd6a
Compare
|
I really don't like the picture quality (and size). Could you maybe use this existing image of the board instead? https://templates.blakadder.com/assets/device_images/SuperMini-ESP32-C3.webp |
rlneumiller
force-pushed
the
add_board_esp32c3_supermini
branch
2 times, most recently
from
d2f2ce7
to
7f89d82
Compare
|
@rlneumiller would you please update the board image file name according to the latest standard outlined here #78718 |
rlneumiller
force-pushed
the
add_board_esp32c3_supermini
branch
from
7f89d82
to
8444e0a
Compare
marekmatej
previously approved these changes
Oct 16, 2024
|
@nordicjm can you please revisit? |
nordicjm
reviewed
Oct 16, 2024
rlneumiller
force-pushed
the
add_board_esp32c3_supermini
branch
from
8444e0a
to
f30a955
Compare
kartben
requested changes
Nov 21, 2024
kartben
requested changes
Nov 21, 2024
sylvioalves
reviewed
Nov 21, 2024
sylvioalves
reviewed
Nov 21, 2024
sylvioalves
reviewed
Nov 21, 2024
Add support for ESP32-C3 Super Mini board Signed-off-by: Arrel Neumiller <[email protected]>
rlneumiller
force-pushed
the
add_board_esp32c3_supermini
branch
from
f30a955
to
8c6d16c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the board under vendor "others" having been unable to determine
the original board designer\vendor with any confidence
Tested samples:
hello_world
basic/blinky
Signed-off-by: <Arrel Neumiller [email protected]>