Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsystem: bluetooth: Fix uninitialized variable #81633

Merged
merged 1 commit into from
Nov 23, 2024
Merged

subsystem: bluetooth: Fix uninitialized variable #81633

merged 1 commit into from
Nov 23, 2024
+1 −1

Conversation

rruuaanng
Copy link
Collaborator

@rruuaanng rruuaanng commented Nov 20, 2024 •
edited by nordicjm
Loading

Fix uninitialized sec_idx variables scanned by Coverity.

Fixes: #74718

@zephyrbot zephyrbot added area: Bluetooth area: Bluetooth Controller size: XS A PR changing only a single line of code labels Nov 20, 2024
@rruuaanng rruuaanng changed the title subsys: bluetooth: Fix uninitialized variable subsystem: bluetooth: Fix uninitialized variable Nov 20, 2024
@rruuaanng
Copy link
Collaborator Author

what can I say :(

 -- Build files have been written to: /__w/zephyr/zephyr/twister-out/mps3_corstone310_fvp_ns/samples/psa/its/sample.psa.its.tfm/tfm/lib/ext/ethos_u_core_driver-subbuild
[1/9] Creating directories for 'ethos_u_core_driver-populate'
[1/9] Performing download step (git clone) for 'ethos_u_core_driver-populate'
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': Failed to connect to review.mlplatform.org port 443 after 129420 ms: Connection timed out
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': Failed to connect to review.mlplatform.org port 443 after 131045 ms: Connection timed out
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': The requested URL returned error: 502
-- Had to git clone more than once:
          3 times.
CMake Error at ethos_u_core_driver-subbuild/ethos_u_core_driver-populate-prefix/tmp/ethos_u_core_driver-populate-gitclone.cmake:31 (message):
  Failed to clone repository:
  'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver'

@Casales
Copy link
Contributor

Casales commented Nov 20, 2024

what can I say :(

 -- Build files have been written to: /__w/zephyr/zephyr/twister-out/mps3_corstone310_fvp_ns/samples/psa/its/sample.psa.its.tfm/tfm/lib/ext/ethos_u_core_driver-subbuild
[1/9] Creating directories for 'ethos_u_core_driver-populate'
[1/9] Performing download step (git clone) for 'ethos_u_core_driver-populate'
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': Failed to connect to review.mlplatform.org port 443 after 129420 ms: Connection timed out
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': Failed to connect to review.mlplatform.org port 443 after 131045 ms: Connection timed out
Cloning into 'ethos_u_core_driver-src'...
fatal: unable to access 'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver/': The requested URL returned error: 502
-- Had to git clone more than once:
          3 times.
CMake Error at ethos_u_core_driver-subbuild/ethos_u_core_driver-populate-prefix/tmp/ethos_u_core_driver-populate-gitclone.cmake:31 (message):
  Failed to clone repository:
  'https://review.mlplatform.org/ml/ethos-u/ethos-u-core-driver'

I have the same issue. Something broken in the pipeline?

@rruuaanng
Copy link
Collaborator Author

I have the same issue. Something broken in the pipeline?

I don't know, Maybe it exists.

@benediktibk benediktibk mentioned this pull request Nov 20, 2024
Closed
cvinayak
cvinayak requested changes Nov 21, 2024
View reviewed changes
subsys/bluetooth/controller/ll_sw/ull_filter.c Outdated
@@ -1164,7 +1164,7 @@ static void rpa_adv_refresh(struct ll_adv_set *adv)
uint8_t pri_idx;

#if defined(CONFIG_BT_CTLR_ADV_EXT)
uint8_t sec_idx;
uint8_t sec_idx = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uint8_t sec_idx = 0;
uint8_t sec_idx = UINT8_MAX;

@rruuaanng
subsystem: bluetooth: Fix uninitialized variable
db5804c 
Fix uninitialized sec_idx variables scanned by Coverity.

Signed-off-by: James Roy <[email protected]>
@kartben kartben merged commit 72d3449 into zephyrproject-rtos:main Nov 23, 2024
27 checks passed
@rruuaanng rruuaanng deleted the cov-unvar branch November 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvinayak cvinayak cvinayak approved these changes

@nashif nashif nashif approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

@erbr-ot erbr-ot Awaiting requested review from erbr-ot

@kruithofa kruithofa Awaiting requested review from kruithofa

@mtpr-ot mtpr-ot Awaiting requested review from mtpr-ot

@thoh-ot thoh-ot Awaiting requested review from thoh-ot

@wopu-ot wopu-ot Awaiting requested review from wopu-ot

Assignees

@cvinayak cvinayak

Labels
area: Bluetooth Controller area: Bluetooth size: XS A PR changing only a single line of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Coverity CID: 330735] Uninitialized scalar variable in subsys/bluetooth/controller/ll_sw/ull_filter.c
6 participants
@rruuaanng @Casales @nashif @cvinayak @kartben @zephyrbot