Bluetooth: Controller: Fix bt_ctrl to bt_ctlr abbreviation #81773
+24
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Controller is abbreviated as CTLR in contrast to CTRL which is used in the context of Link Layer Control Procedures. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
jhedberg
previously approved these changes
Nov 22, 2024
alwa-nordic
reviewed
Nov 22, 2024
alwa-nordic
reviewed
Nov 22, 2024
cvinayak
force-pushed
the
github_bt_ctrl_to_bt_ctlr_fix
branch
from
72d8d3d
to
3dda4c1
Compare
jhedberg
reviewed
Nov 22, 2024
Comment on lines
495
to
+499
| config BT_CTRL_ADV_ADI_IN_SCAN_RSP | ||
| bool "Include ADI in AUX_SCAN_RSP PDU [DEPRECATED]" | ||
| depends on BT_BROADCASTER && BT_CTLR_ADV_EXT | ||
| select BT_CTLR_ADV_ADI_IN_SCAN_RSP | ||
| select DEPRECATED |
There was a problem hiding this comment.
A bit of a slippery slope effect here, but now that you did the formal deprecation it means that this should also be mentioned in doc/releases/migration-guide-4.1.rst (or maybe it was the release notes - please double check where deprecations are normally listed)
zephyrbot
added
area: Bluetooth
Release Notes
zephyrbot
requested review from
carlescufi,
erbr-ot,
fabiobaltieri,
hermabe,
kartben,
kruithofa,
mtpr-ot,
rugeGerritsen,
sjanc,
Thalley,
theob-pro,
thoh-ot and
wopu-ot
Thalley
requested changes
Nov 22, 2024
doc/releases/migration-guide-4.1.rst
Outdated
| Bluetooth Controller | ||
| ==================== | ||
|
|
||
| * The following Kconfig option have been renamed: |
There was a problem hiding this comment.
Suggested change
| * The following Kconfig option have been renamed: | |
| * The following Kconfig option has been renamed: |
doc/releases/migration-guide-4.1.rst
Outdated
Comment on lines
123
to
124
| * :kconfig:option:`CONFIG_BT_CTRL_ADV_ADI_IN_SCAN_RSP` to | ||
| :kconfig:option:`CONFIG_BT_CTLR_ADV_ADI_IN_SCAN_RSP` |
There was a problem hiding this comment.
Consider whether a list with a single element is the best choice :)
| @@ -489,7 +489,7 @@ Bluetooth | |||
| ``ticks_slot_window``. Implement continuous scanning with it. | |||
| * Added support for considering the SDU interval, along with the packet | |||
| sequence number and time stamps, in SDU fragmentation. | |||
| * Added a new ``BT_CTRL_TX_PWR_DBM`` option to set the TX power directly in | |||
| * Added a new ``BT_CTLR_TX_PWR_DBM`` option to set the TX power directly in | |||
There was a problem hiding this comment.
Suggested change
| * Added a new ``BT_CTLR_TX_PWR_DBM`` option to set the TX power directly in | |
| * Added a new ``BT_CTRL_TX_PWR_DBM`` option to set the TX power directly in |
Old release notes should not be modified
There was a problem hiding this comment.
Old release notes have been modified post release tags to keep the latest documentation link to old release notes fixed for typo, correctness and style changes etc... that is what I see in the history of the release notes files.
@kartben can correct me.
Fix to rename BT_CTRL_ADV_ADI_IN_SCAN_RSP to BT_CTLR_ADV_ADI_IN_SCAN_RSP. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_bt_ctrl_to_bt_ctlr_fix
branch
from
3dda4c1
to
468580f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Controller is abbreviated as CTLR in contrast to CTRL
which is used in the context of Link Layer Control
Procedures.
Fix to rename BT_CTRL_ADV_ADI_IN_SCAN_RSP to
BT_CTLR_ADV_ADI_IN_SCAN_RSP.