hostap: fix VHT channel center segment0 #82113
Conversation
Unless ACS is being used, both "channel" and "vht_oper_centr_freq_seg0_idx" parameters must be set. Fixed "channel center segment 0" not being set in VHT Operation IE. Signed-off-by: Gang Li <[email protected]>
Add "bandwidth" parameter to "wifi ap enable" command. Signed-off-by: Gang Li <[email protected]>
If using embedded supplicant, set bandwidth to driver. Signed-off-by: Gang Li <[email protected]>
zephyrbot
added
area: Networking
area: Wi-Fi
zephyrbot
requested review from
danieldegrasse,
dbaluta,
decsny,
dleach02,
jukkar,
Kludentwo,
krish2718,
manuargue,
MaochenWang1,
MarkWangChinese,
mmahadevan108 and
rlubos
| center_freq_seg0_idx = params->channel; | ||
| break; | ||
| case WIFI_FREQ_BANDWIDTH_40MHZ: | ||
| if (!hostapd_cli_cmd_v("set ht_capab [HT40+][SHORT-GI-40]")) { |
There was a problem hiding this comment.
SHORT-GI should be set as per the underlying driver/chipset capablities
There was a problem hiding this comment.
the choice of HT40+/- should still be user configurable, no? 36-40MHz-HT40+ === 40-40MHz-HT40- == 38.
There was a problem hiding this comment.
When starting soft AP, it cannot get the driver/chipset capabilities.
What do you think about putting these configurations in the "wifi ap config" command?
Before starting the AP, users can freely set it, similar to the hostapd.conf file.
| if (params->bandwidth != WIFI_FREQ_BANDWIDTH_20MHZ) | ||
| { | ||
| chan_idx = params->channel; | ||
| for (index = 0; index < index_max; index++) | ||
| { | ||
| if ((chan_idx >= (center_freq[index] - ch_offset)) && (chan_idx <= (center_freq[index] + ch_offset))) | ||
| { | ||
| center_freq_seg0_idx = center_freq[index]; | ||
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
can't we just do below?
if (params->bandwidth != WIFI_FREQ_BANDWIDTH_20MHZ)
{
center_freq_seg0_idx = params->channel + ch_offset;
}
We don't even need the static array of frequencies? Of course +/- depends on the HT40+/- user input.
There was a problem hiding this comment.
Yes, I will check it.
| @@ -560,6 +560,8 @@ struct wifi_connect_req_params { | |||
| const uint8_t *identities[WIFI_ENT_IDENTITY_MAX_USERS]; | |||
| /** User Passwords */ | |||
| const uint8_t *passwords[WIFI_ENT_IDENTITY_MAX_USERS]; | |||
| /** Parameter used for frequency band */ | |||
| enum wifi_frequency_bandwidths bandwidth; | |||
There was a problem hiding this comment.
this commit should be the first one as VHT seg0 frequency relies on the this param
|
FYI @nxf58150 |
No description provided.