Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with keys #2

Open
mahmoudbahaa opened this issue Mar 28, 2024 · 0 comments
Open

Issues with keys #2

mahmoudbahaa opened this issue Mar 28, 2024 · 0 comments

Comments

@mahmoudbahaa
Copy link

FIrst thanks forthe good utility but the library has the following issues:

  1. dirOrFileExists has a bug where it return true even if the file doesn't exist
  2. keys must be valid file names which is not always the case.

I fixed the above issue and made a PR here

#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant