Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try implementing issue 45 from the original repo. #1

Open
zerobandwidth opened this issue Jan 4, 2018 · 0 comments
Open

Try implementing issue 45 from the original repo. #1

zerobandwidth opened this issue Jan 4, 2018 · 0 comments
Assignees
@zerobandwidth
Labels
enhancement New feature or request

Comments

@zerobandwidth
Copy link

Implement a solution for Issue 45, which we submitted to the original repository, and submit a PR back to it.
@zerobandwidth zerobandwidth added the enhancement New feature or request label Jan 4, 2018
@zerobandwidth zerobandwidth self-assigned this Jan 4, 2018
ist-pasha pushed a commit that referenced this issue Jan 5, 2018
@zerobandwidth
(#1) Implemented calculateBounds() and several unit tests thereof.
c2374c1
ist-pasha pushed a commit that referenced this issue Jan 5, 2018
@zerobandwidth
(#1) Hey, derpy, how about finishing the feature.
7922283
ist-pasha pushed a commit that referenced this issue Jan 5, 2018
@zerobandwidth
(#1) Corrected some bounding code, added unit tests.
60f0066 
Made changes and added sufficient tests to not only verify the feature but also kill all Lint warnings in files that I modified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerobandwidth zerobandwidth

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zerobandwidth