Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyre.set_interface is not implemented #163

Open
philrhc opened this issue Nov 28, 2024 · 3 comments
Open

pyre.set_interface is not implemented #163

philrhc opened this issue Nov 28, 2024 · 3 comments

Comments

@philrhc
Copy link

philrhc commented Nov 28, 2024

i will try taking a stab at submitting a patch if someone will review it :)
it seems that adding automated tests for it will be a little bit difficult so happy to get any pointers

logging.debug("set_interface not implemented") #TODO

thanks!

@sphaero
Copy link
Contributor

sphaero commented Nov 28, 2024

send a PR and I will happily review it

@philrhc
Copy link
Author

philrhc commented Dec 2, 2024

thanks! i've submitted a pr: #164
i've tested it but any suggestions for automated tests would be appreciated...

@sphaero
Copy link
Contributor

sphaero commented Dec 2, 2024

I need to find some time, it's been a while that I touched Pyre. I already noticed you also changed whitespace. Rather not do that as it requires more effort of reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants