Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anywhere that loops over the data in Lambda function should move to CMS #1

Open
simonprickett opened this issue Jun 14, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@simonprickett
Copy link
Contributor

simonprickett commented Jun 14, 2018

Move any looping over data to filter it into the CMS. Endpoints requiring this are:

  • traits.json
  • readings.json
  • starsigns.json
@simonprickett simonprickett added the enhancement New feature or request label Jun 14, 2018
@simonprickett simonprickett self-assigned this Jun 14, 2018
@simonprickett
Copy link
Contributor Author

Example - for traits, the URL should take a request parameter and the CMS should filter for this without the client code in the Lambda function having to do it:

http://zestyscopes.zesty.site/-/custom/traits.json?sign=Aries

@simonprickett
Copy link
Contributor Author

Traits might be interesting to do as there's no sign name in the traits as such, it's a lookup based off of the zuid.

@simonprickett
Copy link
Contributor Author

simonprickett commented Jun 27, 2018

Done starsigns on the backend, and changed the endpoint name as it's only used this way for mascots e.g:

http://zestyscopes.zesty.site/-/custom/starsignbymascot.json?mascot=The%20Scorpion

Alexa skill code needs updating to use this too.

@simonprickett
Copy link
Contributor Author

readings.json will also have the same lookup from the zuid challenge that traits currently does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant