Description

There is error-checking in the importer that makes sure we don't try to import (or even validate on the server) rows that are invalid in some way. One such way is when we try to import a person which has no first name or last name. The same checks also warn against importing without an ID. But it seems that when you configure an import without an ID, the warning about missing ID obscures the deal-breaker error that should be displayed because there is no name.

Steps to reproduce

1. Go to https://app.dev.zetkin.org/organize/1/people
2. Click on "Create"
3. Click on "Import people"
4. Pick a file that contains names but not IDs (see example CSV below)
5. Configure first name and last name column
6. Click preview

Example CSV

FNAME,LNAME,EMAIL
Clara,Zetkin,[email protected]
Clara,,[email protected]

Expected Behaviour

A red error should be displayed (instead of the yellow warning) letting the user know that there is no ID or name on one row. Internally in the code, this problem is called ImportProblemKind.MISSING_ID_AND_NAME.

Actual Behaviour

A yellow warning about missing ID is displayed, but can be bypassed by the user (even though the import will fail on the next step).

Screenshots (if you have any)

Note how the HTTP request has failed, because the client tried to make the request even though it should have found that there was a missing name and stopped.

Proposed solution

Add a test case for this in predictProblems.spec.ts and tweak predictProblems() to catch the problem.