Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two issues deploying grid with extra columns #887

Open
rppala3 opened this issue Mar 10, 2013 · 1 comment
Open

Two issues deploying grid with extra columns #887

rppala3 opened this issue Mar 10, 2013 · 1 comment

Comments

@rppala3
Copy link

rppala3 commented Mar 10, 2013

When I add extra columns to the table, I saw that in the relevant json generated on deploy the 'name' property of new columns is missing.
This causes problems side: the new columns are uncontrollable.
(file: library/Bvb/Grid.php, function _buildTitles(), rows: 1914, 2019)

Then I saw the columns are always sortable because the property 'sortable' is missing too.
(file: library/Bvb/Grid/Deploy/JqGrid.php, function jqgGetColumnModel(), row: 955)

I corrected these issues but I don't know how to write and post the patch.
How can I do?

@imonteiro
Copy link
Member

Hi,

You can fork this repository (https://help.github.com/articles/fork-a-repo), do the changes and finally use a pull request (https://help.github.com/articles/using-pull-requests).
If you prefer you can paste here the code and I can commit it.

Thanks for you fix.

Best Regards,
Ivo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants