Skip to content

Commit 3702282

Browse files
[distro] refactor: cleanup dependencies in setup script (Jiayi-Pan#37)
* [distro] refactor: cleanup dependencies in setup script * Update requirements.txt
1 parent 70bfe9b commit 3702282

File tree

2 files changed

+17
-25
lines changed

2 files changed

+17
-25
lines changed

requirements.txt

+11-9
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
transformers
2-
hydra-core
3-
tensordict==0.5.0
4-
numpy
5-
pytest
6-
pybind11
1+
# vllm==0.6.3 # vllm is installed in image building to avoid ray conflicts
2+
# TODO: add version info to requirements
3+
accelerate
74
codetiming
8-
yapf
9-
wandb
10-
git+https://github.com/NVIDIA/TransformerEngine.git@stable
5+
datasets
6+
dill
7+
hydra-core
8+
numpy
9+
pybind11
10+
ray==2.10
11+
tensordict
12+
transformers

setup.py

+6-16
Original file line numberDiff line numberDiff line change
@@ -20,29 +20,19 @@
2020
with open(os.path.join(version_folder, 'verl/version/version')) as f:
2121
__version__ = f.read().strip()
2222

23-
# TODO: add version info to requirements
24-
install_requires = [
25-
'torch==2.4.0',
26-
'tensordict',
27-
'transformers',
28-
'codetiming',
29-
'pybind11',
30-
'hydra-core',
31-
'numpy',
32-
'yapf',
33-
"dill",
34-
"accelerate"
35-
]
23+
24+
with open('requirements.txt') as f:
25+
required = f.read().splitlines()
26+
install_requires = [item.strip() for item in required if item.strip()[0] != '#']
3627

3728
install_optional = [
3829
'vllm==0.6.3',
30+
'torch==2.4.0', # required by vllm
3931
]
4032

4133
extras_require = {
42-
'demo': ['hydra-core', 'transformers', ''],
4334
'single-controller': ['ray', 'kubernetes'],
44-
'single-controller-ray': ['ray'],
45-
'test': ['fsspec', 'pytest', 'datasets']
35+
'test': ['pytest']
4636
}
4737

4838
from pathlib import Path

0 commit comments

Comments
 (0)