Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zeroize Support #12

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Add Zeroize Support #12

merged 3 commits into from
Nov 24, 2023

Conversation

rahulbhalla3521
Copy link
Contributor

Change Summary:

  • Adds support for the zeroize crypto domain endpoint which clears the cryptographic keys and non-compliance mode settings within the given domain (which must have an access-mode of "control-usage") of the given crypto adapter.

Endpoint details:

  • POST /api/partitions/{partition-id}/operations/zeroize-crypto-domain
  • Request:
    • crypto-adapter-URI; string (struct CryptoAdapterDetails)
    • domain-index; int (struct CryptoAdapterDetails)

@rahulbhalla3521 rahulbhalla3521 self-assigned this Nov 15, 2023
jiangphcn
jiangphcn approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@jiangphcn jiangphcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

huoqifeng
huoqifeng approved these changes Nov 17, 2023
View reviewed changes
Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huoqifeng
Copy link

@rahulbhalla3521 would you please resolve the conflict before merge?

@rahulbhalla3521 rahulbhalla3521 merged commit ddb0004 into master Nov 24, 2023
1 check passed
@rahulbhalla3521 rahulbhalla3521 deleted the zeroize-support branch November 24, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangphcn jiangphcn jiangphcn approved these changes

@huoqifeng huoqifeng huoqifeng approved these changes

@andy-maier andy-maier Awaiting requested review from andy-maier

Assignees

@rahulbhalla3521 rahulbhalla3521

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rahulbhalla3521 @huoqifeng @jiangphcn @rahulb3521