Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for logon/logoff and named sessions #685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Dec 25, 2024

TODOs:

  • Add end2end testcases for the new 'session logon/logoff' commands

@andy-maier andy-maier self-assigned this Dec 25, 2024
@andy-maier andy-maier added this to the 1.13.0 milestone Dec 25, 2024
@andy-maier andy-maier linked an issue Dec 25, 2024 that may be closed by this pull request
@andy-maier andy-maier force-pushed the andy/named-sessions branch 5 times, most recently from cb95f11 to 821d57b Compare December 27, 2024 06:05
@coveralls
Copy link

coveralls commented Dec 27, 2024

Coverage Status

coverage: 37.891% (+1.3%) from 36.569%
when pulling 9261bc9 on andy/named-sessions
into b70aed0 on master.

@andy-maier andy-maier force-pushed the andy/named-sessions branch 2 times, most recently from 82974eb to e6651cf Compare December 29, 2024 12:37
@andy-maier andy-maier force-pushed the andy/named-sessions branch 6 times, most recently from 0253caf to 2a657a3 Compare December 31, 2024 06:26
TODOs:

* Add end2end testcases for the new 'session logon/logoff' commands

Details:

* Added new 'zhmc session logon/logoff' commands that manage the session
  in a file '.zhmc_sessions.yaml' in the user's home directory.

* Deprecated the existing 'zhmc session create/delete' commands since they
  are less convenient to use compared to the new logon/logoff commands,
  and cannot be used as intended on Windows due to the displayed export/unset
  commands.

* Added a general option '-s' / '--session-name' for specifying the name
  of the session that is managed in the '.zhmc_sessions.yaml' file.
  This allows having multiple sessions to different HMCs open at the same
  time, and selecting them by name. If not specified, the session name is
  'default'.

* The 'session delete' command was changed to unset all ZHMC_* environment
  variables, instead of just ZHMC_SESSION_ID.

* If logon options and ZHMC_* environment variables are both specified,
  the logon options now have precedence and none of the ZHMC_* environment
  variables is used (except ZHMC_PASSWORD). This changes the earlier
  behavior where ZHMC_SESSION_ID was used even when logon options were
  specified.

* The existing testcases for sessions were adjusted for the new behavior.

* Added function testcases for the new _session_file.py module.

* The end2end testcases for the _cmd_sessions.py module were extended with
  new testcases.

Signed-off-by: Andreas Maier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for having sessions to multiple HMCs
2 participants