Gun 2.0/master incompatibility

[michaelklishin]

This is a heads-up. I accidentally built this plugin in an environment that cloned gun master, and there were exceptions around opening a connections (something about options validation failing, unfortunately I no longer have the logs). We might want to test against Gun 2.0 RCs early.

[lhoguin]

The difference is that in Gun 1.x the TCP and TLS options are given as a single list (transport_opts), while in 2.0 the lists are separate (tcp_opts and tls_opts).

[enjolras1205]

i tried to upgrade to gun2.0, is harder than expected.

https://ninenines.eu/docs/en/gun/2.0/guide/migrating_from_1.3/
i found three breaking change:

1. tcp_opts and tls_opts，there will cause a eetcd breaking change too.
2. use gun:headers to new stream。
   

diff --git a/src/eetcd_stream.erl b/src/eetcd_stream.erl
index cdcb980..8217521 100644
--- a/src/eetcd_stream.erl
+++ b/src/eetcd_stream.erl
@@ -10,21 +10,21 @@
 -include("eetcd.hrl").
 
 -spec new(Name, Path) -> {ok, GunPid, Http2Ref} when
     Name :: name(),
     Path :: iodata(),
     GunPid :: pid(),
     Http2Ref :: reference().
 new(Name, Path) ->
     case eetcd_conn:round_robin_select(Name) of
         {ok, Pid, Headers} ->
-            Ref = gun:request(Pid, <<"POST">>, Path, Headers, <<>>),
+            Ref = gun:headers(Pid, <<"POST">>, Path, Headers, #{}),
             {ok, Pid, Ref};

3. eetcd_stream:await/await_body will change to gun:await/await_body。and consider new gun_tunnel_up message.
   

[michaelklishin]

Thank you for taking the time to investigate.

[zhongwencool]

i tried to upgrade to gun2.0, is harder than expected.

https://ninenines.eu/docs/en/gun/2.0/guide/migrating_from_1.3/ i found three breaking change:

1. tcp_opts and tls_opts，there will cause a eetcd breaking change too.
2. use gun:headers to new stream。
   

diff --git a/src/eetcd_stream.erl b/src/eetcd_stream.erl
index cdcb980..8217521 100644
--- a/src/eetcd_stream.erl
+++ b/src/eetcd_stream.erl
@@ -10,21 +10,21 @@
 -include("eetcd.hrl").
 
 -spec new(Name, Path) -> {ok, GunPid, Http2Ref} when
     Name :: name(),
     Path :: iodata(),
     GunPid :: pid(),
     Http2Ref :: reference().
 new(Name, Path) ->
     case eetcd_conn:round_robin_select(Name) of
         {ok, Pid, Headers} ->
-            Ref = gun:request(Pid, <<"POST">>, Path, Headers, <<>>),
+            Ref = gun:headers(Pid, <<"POST">>, Path, Headers, #{}),
             {ok, Pid, Ref};

3. eetcd_stream:await/await_body will change to gun:await/await_body。and consider new gun_tunnel_up message.
   

We'll likely accept a PR(0.4.0) that upgrade to gun 2.0

[enjolras1205]

hope to submit in early October.