Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mirrors for downloading Zig (and ZLS?) tarballs #238

Open
Vexu opened this issue Oct 14, 2024 · 2 comments · May be fixed by #230
Open

Use mirrors for downloading Zig (and ZLS?) tarballs #238

Vexu opened this issue Oct 14, 2024 · 2 comments · May be fixed by #230

Comments

@Vexu
Copy link
Member

Vexu commented Oct 14, 2024

Similar to https://github.com/mlugg/setup-zig this extension should also support using mirrors for downloading Zig tarballs.

I'd prefer updating the mirror list to not require updating the extension.

@Techatrix
Copy link
Collaborator

It shouldn't be too difficult to implement this on top of #230. I anticipated that mirrors could be added to this extension so I tried to plan ahead by adding minisign verification as an example.

I'd prefer updating the mirror list to not require updating the extension.

Does this mean that the mirror list is supposed to be configurable by the user?

@Vexu
Copy link
Member Author

Vexu commented Oct 14, 2024

It shouldn't be too difficult to implement this on top of #230. I anticipated that mirrors could be added to this extension so I tried to plan ahead by adding minisign verification as an example.

I suspected that to be the case, good to get confirmation.

I'd prefer updating the mirror list to not require updating the extension.

Does this mean that the mirror list is supposed to be configurable by the user?

It doesn't have to be but that does seems like something someone could want. I was thinking there could be a mirror list hosted somewhere (maybe ziglang.org/download/mirrors.json) that the extension could check regularly.

Techatrix added a commit that referenced this issue Nov 22, 2024
For now, the list of mirrors has been manually copied over from mlugg/setup-zig. Adding mirrors for ZLS is also possible even though none exist.

fixes #238
@Techatrix Techatrix linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants