Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change with InvalidUtf8 as zig introduces Wtf8 #1797

Closed
AlexBlandin opened this issue Feb 27, 2024 · 1 comment · Fixed by #1794
Closed

Breaking change with InvalidUtf8 as zig introduces Wtf8 #1797

AlexBlandin opened this issue Feb 27, 2024 · 1 comment · Fixed by #1794
Labels
bug Something isn't working

Comments

@AlexBlandin
Copy link

AlexBlandin commented Feb 27, 2024

Zig Version

0.12.0-dev.3008+b2374c4d7

Zig Language Server Version

845a9a0

Client / Code Editor / Extensions

No response

Steps to Reproduce and Observed Behavior

Build ZLS nightly on Windows with Zig nightly as of 6c2eb0f131588be111652a755a4492ff72d16440, corresponding to merging ziglang/zig#19005 two days ago.

Compilation exits due to an error set mismatch in known-folders.zig, which I've reported accordingly (ziglibs/known-folders#46), however just as ZLS is dealing with breaking changes elsewhere in Zig nightly, it may also have to deal with them here in preparation for 0.12, though I've not got the bandwidth to manually fix and check if it continues to build and passes tests.

Expected Behavior

ZLS compiles as normal.

Relevant log output

> zig build
install
└─ install zls
   └─ zig build-exe zls Debug native 1 errors
C:\Users\alexb\AppData\Local\zig\p\12209925016f4b5486a713828ead3bcc900fa4f039c93de1894aa7d5253f7633b92c\known-folders.zig:100:29: error: expected type 'error{OutOfMemory,InvalidWtf8,EnvironmentVariableNotFound}', found 'error{InvalidUtf8}'
                            error.InvalidUtf8 => return null,
                            ^~~~~~~~~~~~~~~~~
C:\Users\alexb\AppData\Local\zig\p\12209925016f4b5486a713828ead3bcc900fa4f039c93de1894aa7d5253f7633b92c\known-folders.zig:100:29: note: 'error.InvalidUtf8' not a member of destination error set
referenced by:
    comptime_0: C:\Users\alexb\AppData\Local\zig\p\12209925016f4b5486a713828ead3bcc900fa4f039c93de1894aa7d5253f7633b92c\known-folders.zig:339:9
    remaining reference traces hidden; use '-freference-trace' to see all reference traces
error: the following command failed with 1 compilation errors:
C:\bin\zig\zig.exe build-exe -ODebug --dep exe_options --dep tracy --dep known-folders --dep zls -Mroot=C:\code\zig\zls\src\main.zig -Mexe_options=C:\code\zig\zls\zig-cache\c\0b9c30ddea2c61b29aa9971e1deb8de5\options.zig -ODebug --dep options -Mtracy=C:\code\zig\zls\src\tracy.zig -Mknown-folders=C:\Users\alexb\AppData\Local\zig\p\12209925016f4b5486a713828ead3bcc900fa4f039c93de1894aa7d5253f7633b92c\known-folders.zig --dep known-folders --dep diffz --dep tracy --dep build_options --dep version_data -Mzls=C:\code\zig\zls\src\zls.zig -Moptions=C:\code\zig\zls\zig-cache\c\85d0d8879cce6839a2a4dcf23c53e5d5\options.zig -Mdiffz=C:\Users\alexb\AppData\Local\zig\p\12200d71e4b7029ea56a429e24260c6c0e85a3069b0d4ba85eace21a0fd75910aa64\DiffMatchPatch.zig -Mbuild_options=C:\code\zig\zls\zig-cache\c\7e53829d1ea0122006493119e8b9b4f7\options.zig -Mversion_data=C:\code\zig\zls\zig-cache\o\328408cdc1d92dec548fab4d92e87b51\version_data_master_19780.zig --cache-dir C:\code\zig\zls\zig-cache --global-cache-dir C:\Users\alexb\AppData\Local\zig --name zls --listen=-
Build Summary: 5/8 steps succeeded; 1 failed (disable with --summary none)
install transitive failure
└─ install zls transitive failure
   └─ zig build-exe zls Debug native 1 errors
error: the following build command failed with exit code 1:
C:\code\zig\zls\zig-cache\o\9f088f9bb5978bbefa45ac1174cba596\build.exe C:\bin\zig\zig.exe C:\code\zig\zls C:\code\zig\zls\zig-cache C:\Users\alexb\AppData\Local\zig --seed 0xadf294b1 -Z1c6b4bd0bfd2d3ca
@AlexBlandin AlexBlandin added the bug Something isn't working label Feb 27, 2024
@AlexBlandin AlexBlandin changed the title Breaking change with InvalidUf8 as zig introduces Wtf8 Breaking change with InvalidUtf8 as zig introduces Wtf8 Feb 27, 2024
@llogick
Copy link
Contributor

llogick commented Feb 27, 2024

@llogick llogick linked a pull request Feb 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants