You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
open src/input.zig, go to line 143, change .pop() to .popOrNull()
save file, no build on save error appeared (it works in 0.13)
restart lsp, it give build on save error (zls: no field or member function named 'popOrNull' in 'array_list.ArrayListAligned(u8,null)')
change .popOrNull() back to .pop(), then save
after saved, build on save error persist (doesnt refresh)
restart lsp, build on save error no longer shows
Expected Behavior
build on save diagnostic could refresh normally after save
Relevant log output
----- zls log -----
info ( main ): Starting ZLS 0.14.0 @ '/Users/spedon/.local/share/mise/installs/zls/0.14.0/zls'
info ( main ): Log File: /Users/spedon/Library/Caches/zls/zls.log (info)
info (server): Client Info: Neovim-0.10.4
info (server): Autofix Mode: source.fixall
info (server): added Workspace Folder: file:///Users/spedon/eden/zig/zh
info (server): Set config option 'builtin_path' to "/Users/spedon/Library/Caches/zls/builtin.zig"
info (server): Set config option 'zig_lib_path' to "/Users/spedon/.local/share/mise/installs/zig/0.14.0/lib"
info (server): Set config option 'zig_exe_path' to "/Users/spedon/.local/share/mise/installs/zig/0.14.0/bin/zig"
info (server): Set config option 'build_runner_path' to "/Users/spedon/Library/Caches/zls/build_runner/66ed948cb34b142db738951608c6140d/build_runner.zig"
info (server): Set config option 'global_cache_path' to "/Users/spedon/Library/Caches/zls"
info (server): Loaded config: /Users/spedon/Library/Application Support/zls.json
info (server): Set config option 'enable_build_on_save' to true
info (store ): Loaded build file 'file:///Users/spedon/eden/zig/zh/build.zig'
info (server): trying to start Build-On-Save for'file:///Users/spedon/eden/zig/zh'
info ( main ): Starting ZLS 0.14.0 @ '/Users/spedon/.local/share/mise/installs/zls/0.14.0/zls'
info ( main ): Log File: /Users/spedon/Library/Caches/zls/zls.log (info)
info (server): Client Info: Neovim-0.10.4
info (server): Autofix Mode: source.fixall
info (server): added Workspace Folder: file:///Users/spedon/eden/zig/zh
info (server): Set config option 'builtin_path' to "/Users/spedon/Library/Caches/zls/builtin.zig"
info (server): Set config option 'zig_lib_path' to "/Users/spedon/.local/share/mise/installs/zig/0.14.0/lib"
info (server): Set config option 'zig_exe_path' to "/Users/spedon/.local/share/mise/installs/zig/0.14.0/bin/zig"
info (server): Set config option 'build_runner_path' to "/Users/spedon/Library/Caches/zls/build_runner/66ed948cb34b142db738951608c6140d/build_runner.zig"
info (server): Set config option 'global_cache_path' to "/Users/spedon/Library/Caches/zls"
info (server): Loaded config: /Users/spedon/Library/Application Support/zls.json
info (server): Set config option 'enable_build_on_save' to true
info (store ): Loaded build file 'file:///Users/spedon/eden/zig/zh/build.zig'
info (server): trying to start Build-On-Save for'file:///Users/spedon/eden/zig/zh'
info ( main ): Starting ZLS 0.14.0 @ '/Users/spedon/.local/share/mise/installs/zls/0.14.0/zls'
info ( main ): Log File: /Users/spedon/Library/Caches/zls/zls.log (info)
info (server): Client Info: Neovim-0.10.4
info (server): Autofix Mode: source.fixall
info (server): added Workspace Folder: file:///Users/spedon/eden/zig/zh
info (server): Set config option 'builtin_path' to "/Users/spedon/Library/Caches/zls/builtin.zig"
info (server): Set config option 'zig_lib_path' to "/Users/spedon/.local/share/mise/installs/zig/0.14.0/lib"
info (server): Set config option 'zig_exe_path' to "/Users/spedon/.local/share/mise/installs/zig/0.14.0/bin/zig"
info (server): Set config option 'build_runner_path' to "/Users/spedon/Library/Caches/zls/build_runner/66ed948cb34b142db738951608c6140d/build_runner.zig"
info (server): Set config option 'global_cache_path' to "/Users/spedon/Library/Caches/zls"
info (server): Loaded config: /Users/spedon/Library/Application Support/zls.json
info (server): Set config option 'enable_build_on_save' to true
info (store ): Loaded build file 'file:///Users/spedon/eden/zig/zh/build.zig'
info (server): trying to start Build-On-Save for'file:///Users/spedon/eden/zig/zh'
Have done some investigations myself, it seems the behaviour is caused by the watch implementation
After force it use manual implementation instead of zig's builtin watch, refreshing works normally.
Also, zig build --watch failed to detect file changes made by neovim(havn't try other editor yet), kinda like what happens in ziglang/zig#21905 (my laptop is on macOS 15.3.1 though).
Maybe we can provide a config option to disable watch implementation? I'm willing to make a pr.
Sped0n
changed the title
zls 0.14 build on save diagnostic not refreshing
zls 0.14 build on save diagnostic not refreshing on macOS 15.3.1
Mar 9, 2025
Zig Version
0.14.0
ZLS Version
0.14.0
Client / Code Editor / Extensions
nvim 0.10.4 with nvim-lspconfig
Steps to Reproduce and Observed Behavior
src/input.zig
, go to line 143, change.pop()
to.popOrNull()
zls: no field or member function named 'popOrNull' in 'array_list.ArrayListAligned(u8,null)'
).popOrNull()
back to.pop()
, then saveExpected Behavior
build on save diagnostic could refresh normally after save
Relevant log output
The text was updated successfully, but these errors were encountered: