Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: make Router more strict wrt types of handler functions #121

Open
renerocksai opened this issue Jul 25, 2024 · 0 comments · May be fixed by #125
Open

TODO: make Router more strict wrt types of handler functions #121

renerocksai opened this issue Jul 25, 2024 · 0 comments · May be fixed by #125

Comments

@renerocksai
Copy link
Member

renerocksai commented Jul 25, 2024 •
edited
Loading

e.g. avoid silently accepting handler functions that want to return an error which leads to unexpected pointer issues.
at least comptime-introspect and check if 2nd param (the one after self) is zap.Request and if return type is void as opposed to !void or sth totally different.
@cosmicboots cosmicboots linked a pull request Aug 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type checking to simple_router's handle_func cosmicboots/zap
1 participant
@renerocksai