From 744ffb122e450f1d543626dd3385a082bff942d8 Mon Sep 17 00:00:00 2001 From: Livingstone Asabahebwa Date: Fri, 13 Oct 2023 06:26:18 +0300 Subject: [PATCH] make height and width properties accomodate string values in graphset --- package.json | 1 + types/zingchart/es6/index.d.ts | 4 ++-- types/zingchart/zingchart-tests.ts | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 6e73aeb52012c3..5036767e9e521f 100644 --- a/package.json +++ b/package.json @@ -32,6 +32,7 @@ "@definitelytyped/utils": "latest", "@octokit/core": "^3.5.1", "@octokit/rest": "^16.0.0", + "@types/node": "^20.8.5", "comment-json": "^4.2.3", "d3-array": "^3.0.2", "d3-axis": "^3.0.0", diff --git a/types/zingchart/es6/index.d.ts b/types/zingchart/es6/index.d.ts index 5f433267f9cb82..1b817139a639a8 100644 --- a/types/zingchart/es6/index.d.ts +++ b/types/zingchart/es6/index.d.ts @@ -13069,7 +13069,7 @@ declare namespace zingchart { /** * Sets the height of the object. 10 | "20px" | 0.3 | "30%" | ... */ - height?: number; + height?: string | number; /** * Sets the line style of the object. "solid" | "dotted" | "dashed" | "dashdot" */ @@ -13082,7 +13082,7 @@ declare namespace zingchart { /** * Sets the width of the object. 10 | "20px" | 0.3 | "30%" | ... */ - width?: number; + width?: string | number; "3d-aspect"?: { /** * Sets the view angle when using the isometric 3D engine. Value can be between 0 and 90, with the default viewing angle being 45°. 5 diff --git a/types/zingchart/zingchart-tests.ts b/types/zingchart/zingchart-tests.ts index c272b13f1e3d56..b161aa2d497ed8 100644 --- a/types/zingchart/zingchart-tests.ts +++ b/types/zingchart/zingchart-tests.ts @@ -204,7 +204,7 @@ const chartConfig: zc.graphset[] = [ alpha: 0, }, { - backgroundColor: "red", + backgroundColor: "green", }, ], },