Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch broken in dist/zingtouch.min.js #46

Closed
mvanderkamp opened this issue Aug 17, 2018 · 1 comment
Closed

Pinch broken in dist/zingtouch.min.js #46

mvanderkamp opened this issue Aug 17, 2018 · 1 comment

Comments

@mvanderkamp
Copy link
Contributor

I have no idea what's causing this, because I'm not familiar with your setup. But here's what's happening:

I've been directly referencing the client library with a <script> tag that points to dist/zingtouch.js so that I could debug. When I switch to webpack to compile my client-side code, I insert a line such as:

const ZingTouch = require('zingtouch');

From index.js I see that this, without changing anything, will require ./dist/zingtouch.min.js instead of ./dist/zingtouch.js.

Now, suddenly, Pinches break. They simply never get called.

If edit index.js to require ./dist/zingtouch.js, everything works again.

Did you forget to rebuild the minified code?

@mvanderkamp
Copy link
Contributor Author

Oops sorry I just realized this is the same issue as #45 except that I got Pinch and Expand confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant