Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two same addresses in the addressbook - address duplicate #23

Closed
juanky201271 opened this issue Apr 6, 2023 · 4 comments
Closed

two same addresses in the addressbook - address duplicate #23

juanky201271 opened this issue Apr 6, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@juanky201271
Copy link
Contributor

The App check about the same label but no about the same address... I don't know if make any sense to have the same address under different labels.

@zancas What do you think? this make sense?

@juanky201271 juanky201271 self-assigned this Apr 6, 2023
@zancas
Copy link
Member

zancas commented Apr 6, 2023

It's plausible that this caused by the same bug as the memo-duplication that @AloeareV is working on. Can we add a test that surfaces this bug? @fluidvanadium ?

@juanky201271
Copy link
Contributor Author

Oh, this is more simple then that... sorry for my bad explanation... I'm going to try again:
In zingo-pc you can create the address book by yourself (it is a JSON file in the PC) and you have to fill two values to add a row, label & address. You manually can create the number of rows that you want, filling the label and copy/paste whatever address you want. It's for now, a really rustic feature.

And I noticed these:

  • you cannot create two records with the same label (I feel this is correct)
  • you CAN create two records with the same address (here is my question... I don't know if this make sense or not).

Maybe all of this doesn't matter because in a short term we have to change this behavior aligned with the new zingolib-memo implementation... @zancas

@zancas
Copy link
Member

zancas commented Apr 6, 2023

Ahh... I see interesting. I am not ready to have an opinion on this. I need to think about it.

@juanky201271 juanky201271 added the enhancement New feature or request label Oct 19, 2023
@juanky201271
Copy link
Contributor Author

Closing this in favor of: #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants