Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parse passwords with arbitrary colons #3201

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Parse passwords with arbitrary colons #3201

wants to merge 4 commits into from

Conversation

mobley-trent
Copy link

Closes #3193
/claim #3193

@algora-pbc algora-pbc bot mentioned this pull request Nov 9, 2024
Open
@mobley-trent mobley-trent marked this pull request as ready for review November 9, 2024 10:02
@mobley-trent
Copy link
Author

mobley-trent commented Nov 11, 2024 •
edited
Loading

AuthSpec test suite is passing locally, is it a flaky test suite ?

@mobley-trent
Copy link
Author

@987Nabil kindly review

@mobley-trent
Copy link
Author

PTAL @jdegoes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes Awaiting requested review from jdegoes jdegoes is a code owner

@vigoo vigoo Awaiting requested review from vigoo vigoo is a code owner

@987Nabil 987Nabil Awaiting requested review from 987Nabil 987Nabil is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing a Basic Authorization header fails if password contains ':'
1 participant
@mobley-trent