Add appendLoggerName aspect #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justcoon
reviewed
Oct 9, 2024
somdoron
force-pushed
the
appendLoggerName
branch
from
1b63abe
to
6c9109c
Compare
somdoron
force-pushed
the
appendLoggerName
branch
from
6c9109c
to
7bec7fe
Compare
justcoon
reviewed
Oct 9, 2024
somdoron
force-pushed
the
appendLoggerName
branch
from
5ea936c
to
3fc5d4e
Compare
|
@somdoron thanks for contribution, i have to take a look on CI issues first ..., as builds are failing currently |
|
hi @somdoron, i think you need to run scalafix |
somdoron
force-pushed
the
appendLoggerName
branch
from
71f55d3
to
cb17fb3
Compare
justcoon
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are upgrading from ZIO 1, where the previous version of zio.logging appended the logger name to the existing logger name. In the new version, it replaces it. This PR suggests introducing a new aspect, appendLoggerName, to append a string to the existing logger name.
Our codebase relies on setting the logger name. For example, when our RPC framework receives an incoming message, we add the service name and method name to the logger name.