Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterByKeys needs to be placed before FilterColumns, examples fixed. #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maratermeshev
Copy link

Problem

/**
 * When using this with FilterColumns make sure it comes FIRST. Otherwise the columns are you filtering
 * may have been nullified in the SQL before the filteration has actually happened.
 */

Examples show incorrect order of FilterByKeys and FilterColumns methods use.

Solution

Put FilterByKeys method before FilterColumns in examples.

@getquill/maintainers

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants