Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential minor bug #65

Open
Abyssaledge opened this issue Dec 12, 2024 · 0 comments
Open

Potential minor bug #65

Abyssaledge opened this issue Dec 12, 2024 · 0 comments

Comments

@Abyssaledge
Copy link

Great work!
When I take a quick look at your code, there seems to be a potential minor bug for waymo point cloud projection at https://github.com/ziyc/drivestudio/blob/main/datasets/waymo/waymo_utils.py#L47.

I don't know if it is a simplification made by the author, but I believe it would be better to specify the accurate rolling shutter status for each camera, instead of directly using global shutter. That will be like

        extrinsic = tf.reshape(
            tf.constant(list(cc.extrinsic.transform), dtype=tf.float64),
            [4, 4])
        intrinsic = tf.constant(list(cc.intrinsic), dtype=tf.float64)
        metadata = tf.constant([
            cc.width,
            cc.height,
            cc.rolling_shutter_direction,
        ], dtype=tf.int32)
        camera_image_metadata = tf.constant([
            *img.pose.transform,
            img.velocity.v_x, img.velocity.v_y, img.velocity.v_z,
            img.velocity.w_x, img.velocity.w_y, img.velocity.w_z,
            img.pose_timestamp,
            img.shutter,
            img.camera_trigger_time,
            img.camera_readout_done_time
        ], dtype=tf.float64)

FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant