Advection refactor #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important changes in this refactor are:
LevelSetEvolution, this has interfaces for evolve! (replacingadvect!),reinit, andget_dof_Δ. The last of which is a convenience function that we use in Optimisers for the stopping criteria.AdvectionStencil->HamiltonJacobiEvolution <: LevelSetEvolution. The idea of this is that other ODE solvers can be implemented in future by implemented, for example,HamiltonJacobiEvolutionRK4. We may be able to leverage Gridap ODE features later down the line as well.Stencilnow has an additional interfacecheck_order. This should check the order of the supplied FE space and return an error if it is not sufficient to give correct results in parallel.src/LevelSetEvolution.Are you happy with this @JordiManyer ?