Skip to content
This repository has been archived by the owner on Jun 12, 2022. It is now read-only.

Handle highWaterMark potentially false #72

Open
wants to merge 2 commits into
base: latest
Choose a base branch
from
Open

Handle highWaterMark potentially false #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbbd29e
fix(cache): handle highWaterMark potentially false
adiktofsugar Oct 21, 2019
da122f9
fix(cache): standard
adiktofsugar Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@ module.exports = class Cache {
cacheTargetStream ? cacheTargetStream.end(done) : done()
})
const oldBody = response.body
const newBody = through({highWaterMark: fitInMemory && MAX_MEM_SIZE})
// in readable-stream 3.x, false is not a valid value for highWaterMark
const highWaterMark = fitInMemory ? MAX_MEM_SIZE : undefined
const newBody = through({highWaterMark})
response.body = newBody
oldBody.once('error', err => newBody.emit('error', err))
newBody.once('error', err => oldBody.emit('error', err))
Expand Down