Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/clean up and documentation #18

Merged
merged 6 commits into from
Jul 4, 2024
Merged

Feat/clean up and documentation #18

merged 6 commits into from
Jul 4, 2024

Conversation

JohnGuilding
Copy link
Collaborator

@JohnGuilding JohnGuilding commented Jul 3, 2024 •
edited
Loading

This PR:

  • Adds natspec missing since recent contract changes
  • Updates readme to document all contracts
  • Updates diagram in readme
  • Uses pnpm for dependency management instead of pnpm and forge submodules
  • Minor directory changes (move factories into dedicated directory, deletes unused files, moves zksync lib into libraries directory)

@JohnGuilding JohnGuilding force-pushed the feat/clean-up-and-documentation branch from bc0034e to a256283 Compare July 4, 2024 08:43
@JohnGuilding JohnGuilding marked this pull request as ready for review July 4, 2024 13:43
@JohnGuilding JohnGuilding merged commit 4e70316 into main Jul 4, 2024
4 checks passed
@JohnGuilding JohnGuilding deleted the feat/clean-up-and-documentation branch July 4, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoraSuegami SoraSuegami SoraSuegami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnGuilding @SoraSuegami