fix incorrect dos date conversion #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coeur
force-pushed
the
coeur/mz_zip_dosdate_to_raw_tm
branch
from
0dfca3d
to
1c363f8
Compare
nmoinvaz
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
dos_dateis1,mz_zip_dosdate_to_raw_tmshould return a date in year 1979.But the cast with
(uint16_t)is incorrectly converting-1to65535, which turns the date to year 7441.The issue may have originated from 35c6102 or earlier (in unzip.c,
ptm->tm_mon = (uInt)((((uDate)&0x1E0)/0x20)-1) ;)It was fixed in the legacy minizip about three years ago:
madler/zlib@2014a99