-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modules that are shipped with Znuny to list in Environment module. #87
Open
reneeb
wants to merge
8
commits into
dev
Choose a base branch
from
cpan-update/reneeb_add_modules_to_environment
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennykorsukewitz
added
1 - 💎 code quality
Code quality improvements to existing code or addition of unit tests.
2 - System/Environment
3 - wait for reviewer
Znuny, it's your turn.
4 - clarification
The issue or pull requests needs more information.
labels
Jun 15, 2021
dennykorsukewitz
changed the title
add modules that are shipped with Znuny to list in Environment module
Add modules that are shipped with Znuny to list in Environment module.
Jun 15, 2021
dennykorsukewitz
removed
the
4 - clarification
The issue or pull requests needs more information.
label
Sep 8, 2022
Hi @reneeb could you please check this failed UnitTest.
Thank you 🚀 |
dennykorsukewitz
added
3 - wait for contributor
Contributor, it's your turn.
and removed
3 - wait for reviewer
Znuny, it's your turn.
labels
Sep 9, 2022
@reneeb , do you have any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1 - 💎 code quality
Code quality improvements to existing code or addition of unit tests.
2 - Backend
2 - System
System/**
3 - wait for contributor
Contributor, it's your turn.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
In Kernel::System::Environment there's a list of modules of (some) modules shipped with Znuny. This list is incomplete and this can be annoying (especially if you want to check the module versions with the "new" CPANUpdate command). This change adds all modules that are shipped with Znuny but missing in the list.
Type of change
Checklist