Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-hidden="true" even when buttons are hidden #33

Open
vuice opened this issue Nov 21, 2019 · 2 comments
Open

aria-hidden="true" even when buttons are hidden #33

vuice opened this issue Nov 21, 2019 · 2 comments

Comments

@vuice
Copy link

vuice commented Nov 21, 2019

I am trying to understand the reasoning behind why 'aria-hidden' is set to 'true' at all, as screen readers need to read what's inside the clamp regardless of it being truncated or not. If there is a logical reason, then I would like to request an enhancement that when we set 'buttons' attribute to 'false', that 'aria-hidden' is also set to 'false'.

@LordOfCorners
Copy link

+1. I made a pull request to address it last week.
#34

@jwaggener
Copy link

I've run into this problem with an accessibility audit. - aria-hidden true on text that is not to be expanded comes up as an issue for screenreaders. I've looked at @LordOfCorners PR and agree this would solve my issue.
My only additional observation would be - even if text is clamped, a person using a screen reader would want to know it is there, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants