Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not measuring line height again when the window has resived #35

Open
LeeCheneler opened this issue Dec 18, 2019 · 1 comment
Open

Not measuring line height again when the window has resived #35

LeeCheneler opened this issue Dec 18, 2019 · 1 comment

Comments

@LeeCheneler
Copy link

Many code bases change font size depending on what breakpoints are hit in their application. When clamping text on a window resize you should remeasure the line height of the text as it could have changed.

As an example in our application the font size is smaller on mobile so we end up with a clamp of 3 lines perfectly at desktop, but if I resize my browser to make it smaller then the clamp is 4 lines.

@arthurmmedeiros
Copy link

Any update on this? I just figured that when resizing the browser the text does get cut again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants