Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking change in ruby-statistics v4: statistics -> ruby_statistics #237

Closed
espen opened this issue Aug 13, 2024 · 1 comment
Closed

breaking change in ruby-statistics v4: statistics -> ruby_statistics #237

espen opened this issue Aug 13, 2024 · 1 comment

Comments

@espen
Copy link

espen commented Aug 13, 2024

https://github.com/estebanz01/ruby-statistics?tab=readme-ov-file#note-regarding-versions-3x-and-4x

the gem got an update that introduced a breaking change in master where the Outermost namespace was changed to be ruby_statistics instead of statistics

Used here:

derailed_benchmarks/lib/derailed_benchmarks/stats_from_dir.rb

Line 4 in b848978

require 'statistics'

jabawack81 added a commit to jabawack81/derailed_benchmarks that referenced this issue Aug 15, 2024
@jabawack81
update requirement in lib/derailed_benchamrks/stats_from_dir.rb
c9423c6 
as mentioned in the issue
zombocom#237 the
`ruby-statistics` gem updated their namespce of their gem from
`statistics` to `ruby-statiscs`
estebanz01/ruby-statistics@baadc9f
and
estebanz01/ruby-statistics@00312b9
this commit is addressing the change
@jabawack81 jabawack81 mentioned this issue Aug 15, 2024
Merged
This was referenced Aug 19, 2024
Closed
Merged
@estebanz01 estebanz01 mentioned this issue Sep 3, 2024
Closed
@pcai
Copy link
Contributor

pcai commented Sep 29, 2024

#239 #238 #241

@pcai pcai closed this as completed Sep 29, 2024
@pcai pcai mentioned this issue Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@espen @pcai