Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature wait for background to exit #88

Open
schneems opened this issue Dec 5, 2024 · 0 comments
Open

Feature wait for background to exit #88

schneems opened this issue Dec 5, 2024 · 0 comments

Comments

@schneems
Copy link
Member

schneems commented Dec 5, 2024

Either add a flag to background.stop or introduce a new command.

Like background.stop(wait_exit: true) might need to add a timeout as well to ensure no deadlock. This would help for heroku run:inside <dyno> "rake db:migrate" where we know it will exit and want to wait for that. Actually, need to double check that the run inside exits when the high level command exits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant