Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLRPCTestTransport appears to be broken #17

Open
mgedmin opened this issue Aug 13, 2019 · 3 comments
Open

XMLRPCTestTransport appears to be broken #17

mgedmin opened this issue Aug 13, 2019 · 3 comments
Assignees
Labels

Comments

@mgedmin
Copy link
Member

mgedmin commented Aug 13, 2019

I noticed this while reading the source code while working on #14, so this is a purely theoretical bug report: XMLRPCTestTransport.request() has this line of code in it:

response = http(request, handle_errors=self.handleErrors)

but the http() function defined at the top level of the same module has this signature:

def http(wsgi_app, string, handle_errors=True):

Thus XMLRPCTestTransport cannot possibly work.

@icemac
Copy link
Member

icemac commented Dec 4, 2019

In 262d9b9 the signature of http() was changed. I used to get the wsgi_app from the WSGILayer before. But this was a too tight coupling.

@icemac
Copy link
Member

icemac commented Dec 4, 2019

After thinking the issue over: I'd suggest to delete the XMLRPC support code here and use the one from zope.app.publisher which also defines the XMLRPC view ZCML directive. I see no way to add tests here without adding a dependency on zope.app.publisher.

@icemac
Copy link
Member

icemac commented Apr 16, 2020

This is already prepared in zopefoundation/zope.app.publisher#8, but still has to be used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants