Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Warn instead of error out for missing .env file of PORT_GIT_DEPS programs? #22

Open
fanbo-meng opened this issue Jun 23, 2022 · 5 comments

Comments

@fanbo-meng
Copy link
Collaborator

For the programs specified for PORT_GIT_DEPS, e.g make, git, they are already pre-installed somewhere on the machine I'm using, but I have to manually create empty .env files under ${HOME}/zot/prod/${dep}/.env in order for the build.sh script to keep going and not report error during checkDeps() step. This gives a bit inconvenience and confusion.

@IgorTodorovskiIBM
Copy link
Collaborator

One other alternative would be to check if the dependency executable can be found in user's PATH (using type) and if it is, do not emit the error

@MikeFultonDev
Copy link
Contributor

For git in particular, we do need a particular level of git to operate. So if we do this, we should also add a check of the git version to make sure it is 'new' enough.

@MikeFultonDev
Copy link
Contributor

I did add 'git' and 'xlclang' version checks to the code. @fanbo-meng I am thinking once we get 'git' built from open source this problem will 'solve itself' since it will then have a .env file?

@fanbo-meng
Copy link
Collaborator Author

fanbo-meng commented Aug 8, 2022

yeah I guess if we always build PORT_GIT_DEPS programs like git from open source and use it in building the actual program then .env would always be there.

@MikeFultonDev
Copy link
Contributor

@fanbo-meng ok to close?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants