Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ui-datepicker-current-day class for selected month #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

florianlacreuse
Copy link

First of all, thank you to maintain this good old montpicker with this fork.

I think using ui-datepicker-today for selected month is a mistake, it should be ui-datepicker-current-day as well as what is done in JQuery UI official datepicker : https://github.com/jquery/jquery-ui/blob/74f8a0ac952f6f45f773312292baef1c26d81300/ui/widgets/datepicker.js#L83.

@zorab47
Copy link
Owner

zorab47 commented Feb 22, 2020

Seems reasonable. I'd imagine this isn't very backward compatible. What do you think the impact would be?

@florianlacreuse
Copy link
Author

Indeed, it's a minor fix. The impact could be visual for somone who override ui-datepicker-today relative css class. In this case he will also need to do it for ui-datepicker-current-day relative css class. Not a big deal IMHO, just need to be said in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants