Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't tap on annotation while annotation tool is active #175

Open
dstillman opened this issue Oct 24, 2024 · 2 comments
Open

Can't tap on annotation while annotation tool is active #175

dstillman opened this issue Oct 24, 2024 · 2 comments
Labels

Comments

@dstillman
Copy link
Member

  1. Select the Underline tool
  2. Select some text
  3. Tap on the annotation

On iOS, this opens the annotation widget, but on Android it doesn't do anything. You have to deselect the tool before you can tap on the annotation.

@dstillman dstillman added the Bug label Oct 24, 2024
@Dima-Android
Copy link
Collaborator

I’ve looked into it and it seems there is a difference between the way PSPDFKIT operates on iOS and Android:
On iOS after the “enterAnnotationCreationMode(annotationTool)” method was called OnAnnotationSelectedListener is getting called when annotation is getting clicked on.

On Android in similar conditions this listener is just not getting called. Not only that, even the onPageClick is not getting called.
In other words we don’t even get info on which point on the document the user clicked, let alone annotation. Only after exitCurrentlyActiveMode is called and we are no longer in annotation editing mode those callbacks are getting called.

@dstillman
Copy link
Member Author

Can we report this to them? This is going to make the latched annotation modes fairly useless — if you use comments at all, there's no point in using latched mode if you have to disable it to create the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants